From: Owen Anderson <resistor@mac.com>
Date: Mon, 18 Feb 2008 02:31:23 +0000 (+0000)
Subject: Fix bugs that Chris noticed in my last patch.
X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=9aa7c35cee0eac0b84212f01abb41ca923f70ec2;p=oota-llvm.git

Fix bugs that Chris noticed in my last patch.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@47252 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/BasicAliasAnalysis.cpp b/lib/Analysis/BasicAliasAnalysis.cpp
index 4c7259f7f4c..b19ce2b8c48 100644
--- a/lib/Analysis/BasicAliasAnalysis.cpp
+++ b/lib/Analysis/BasicAliasAnalysis.cpp
@@ -250,22 +250,30 @@ BasicAliasAnalysis::getModRefInfo(CallSite CS, Value *P, unsigned Size) {
     const Value *Object = getUnderlyingObject(P);
     // Allocations and byval arguments are "new" objects.
     if (Object &&
-        (isa<AllocationInst>(Object) ||
-         (isa<Argument>(Object) &&
-                                 (cast<Argument>(Object)->hasByValAttr() ||
-                                  cast<Argument>(Object)->hasNoAliasAttr())))) {
+        (isa<AllocationInst>(Object) || isa<Argument>(Object))) {
       // Okay, the pointer is to a stack allocated (or effectively so, for 
       // for noalias parameters) object.  If we can prove that
       // the pointer never "escapes", then we know the call cannot clobber it,
       // because it simply can't get its address.
-      if (!AddressMightEscape(Object))
-        return NoModRef;
+      if (isa<AllocationInst>(Object) ||
+          cast<Argument>(Object)->hasByValAttr() ||
+          cast<Argument>(Object)->hasNoAliasAttr())
+        if (!AddressMightEscape(Object)) {
+          for (CallSite::arg_iterator CI = CS.arg_begin(), CE = CS.arg_end();
+              CI != CE; ++CI)
+            if (getUnderlyingObject(CI->get()) == P)
+              return AliasAnalysis::getModRefInfo(CS, P, Size);
+        
+          return NoModRef;
+        }
 
       // If this is a tail call and P points to a stack location, we know that
       // the tail call cannot access or modify the local stack.
-      if (CallInst *CI = dyn_cast<CallInst>(CS.getInstruction()))
-        if (CI->isTailCall() && !isa<MallocInst>(Object))
-          return NoModRef;
+      if (isa<AllocationInst>(Object) ||
+          cast<Argument>(Object)->hasByValAttr())
+        if (CallInst *CI = dyn_cast<CallInst>(CS.getInstruction()))
+          if (CI->isTailCall() && !isa<MallocInst>(Object))
+            return NoModRef;
     }
   }