From: Jim Grosbach <grosbach@apple.com>
Date: Wed, 16 Jun 2010 18:45:08 +0000 (+0000)
Subject: add FIXME
X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=956352eb4682ba7000486d8712a4435a843a48d4;p=oota-llvm.git

add FIXME

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@106126 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/CodeGen/SjLjEHPrepare.cpp b/lib/CodeGen/SjLjEHPrepare.cpp
index a002ef8a628..9aa2b69f65c 100644
--- a/lib/CodeGen/SjLjEHPrepare.cpp
+++ b/lib/CodeGen/SjLjEHPrepare.cpp
@@ -289,6 +289,9 @@ splitLiveRangesAcrossInvokes(SmallVector<InvokeInst*,16> &Invokes) {
       }
 
       // If we decided we need a spill, do it.
+      // FIXME: Spilling this way is overkill, as it forces all uses of
+      // the value to be reloaded from the stack slot, even those that aren't
+      // in the unwind blocks. We should be more selective.
       if (NeedsSpill) {
         ++NumSpilled;
         DemoteRegToStack(*Inst, true);