From: Benjamin Kramer <benny.kra@googlemail.com>
Date: Thu, 23 Feb 2012 13:39:13 +0000 (+0000)
Subject: Strip a layer of boilerplate from the VLIWPacketizer by storing the scheduler as... 
X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=92fc97afa742000aeb81d862abbaaba50b27a000;p=oota-llvm.git

Strip a layer of boilerplate from the VLIWPacketizer by storing the scheduler as an opaque pointer.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@151252 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/include/llvm/CodeGen/DFAPacketizer.h b/include/llvm/CodeGen/DFAPacketizer.h
index d662c13942f..0694caa346a 100644
--- a/include/llvm/CodeGen/DFAPacketizer.h
+++ b/include/llvm/CodeGen/DFAPacketizer.h
@@ -36,7 +36,6 @@ class MachineInstr;
 class MachineLoopInfo;
 class MachineDominatorTree;
 class InstrItineraryData;
-class VLIWPacketizerImpl;
 class SUnit;
 
 class DFAPacketizer {
@@ -92,7 +91,7 @@ class VLIWPacketizerList {
   const TargetInstrInfo *TII;
 
   // Encapsulate data types not exposed to the target interface.
-  VLIWPacketizerImpl *Impl;
+  void *SchedulerImpl;
 
 protected:
   // Vector of instructions assigned to the current packet.
diff --git a/lib/CodeGen/DFAPacketizer.cpp b/lib/CodeGen/DFAPacketizer.cpp
index 5c8feb14668..f0cf290825f 100644
--- a/lib/CodeGen/DFAPacketizer.cpp
+++ b/lib/CodeGen/DFAPacketizer.cpp
@@ -104,8 +104,8 @@ namespace {
 // DefaultVLIWScheduler - This class extends ScheduleDAGInstrs and overrides
 // Schedule method to build the dependence graph.
 //
-// ScheduleDAGInstrs has LLVM_LIBRARY_VISIBILITY so cannot be exposed to the
-// VLIWPacketizerImpl interface, even as an undefined pointer.
+// ScheduleDAGInstrs has LLVM_LIBRARY_VISIBILITY so we have to reference it as
+// an opaque pointer in VLIWPacketizerList.
 class DefaultVLIWScheduler : public ScheduleDAGInstrs {
 public:
   DefaultVLIWScheduler(MachineFunction &MF, MachineLoopInfo &MLI,
@@ -113,18 +113,7 @@ public:
   // Schedule - Actual scheduling work.
   void Schedule();
 };
-}
-
-namespace llvm {
-// Wrapper for holding library-local data types.
-class VLIWPacketizerImpl {
-public:
-  DefaultVLIWScheduler DAGBuilder;
-  VLIWPacketizerImpl(MachineFunction &MF, MachineLoopInfo &MLI,
-                     MachineDominatorTree &MDT, bool IsPostRA)
-    : DAGBuilder(MF, MLI, MDT, IsPostRA) {}
-};
-}
+} // end anonymous namespace
 
 DefaultVLIWScheduler::DefaultVLIWScheduler(
   MachineFunction &MF, MachineLoopInfo &MLI, MachineDominatorTree &MDT,
@@ -143,12 +132,12 @@ VLIWPacketizerList::VLIWPacketizerList(
   bool IsPostRA) : TM(MF.getTarget()), MF(MF)  {
   TII = TM.getInstrInfo();
   ResourceTracker = TII->CreateTargetScheduleState(&TM, 0);
-  Impl = new VLIWPacketizerImpl(MF, MLI, MDT, IsPostRA);
+  SchedulerImpl = new DefaultVLIWScheduler(MF, MLI, MDT, IsPostRA);
 }
 
 // VLIWPacketizerList Dtor
 VLIWPacketizerList::~VLIWPacketizerList() {
-  delete Impl;
+  delete (DefaultVLIWScheduler *)SchedulerImpl;
   delete ResourceTracker;
 }
 
@@ -195,10 +184,11 @@ void VLIWPacketizerList::endPacket(MachineBasicBlock *MBB,
 void VLIWPacketizerList::PacketizeMIs(MachineBasicBlock *MBB,
                                       MachineBasicBlock::iterator BeginItr,
                                       MachineBasicBlock::iterator EndItr) {
-  Impl->DAGBuilder.Run(MBB, BeginItr, EndItr, MBB->size());
+  DefaultVLIWScheduler *Scheduler = (DefaultVLIWScheduler *)SchedulerImpl;
+  Scheduler->Run(MBB, BeginItr, EndItr, MBB->size());
 
   // Remember scheduling units.
-  SUnits = Impl->DAGBuilder.SUnits;
+  SUnits = Scheduler->SUnits;
 
   // Generate MI -> SU map.
   std::map <MachineInstr*, SUnit*> MIToSUnit;