From: Chris Lattner Date: Tue, 16 May 2006 06:45:34 +0000 (+0000) Subject: Add a chain to FORMAL_ARGUMENTS. This is a minimal port of the X86 backend, X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=8c0c10c2b9fef21dcbabac81fffa32f4407a0b7f;p=oota-llvm.git Add a chain to FORMAL_ARGUMENTS. This is a minimal port of the X86 backend, it doesn't currently use/maintain the chain properly. Also, make the X86ISelLowering.cpp file 80-col clean. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@28320 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp b/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp index 1cac1341872..b6472323708 100644 --- a/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp +++ b/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp @@ -2349,6 +2349,7 @@ std::vector TargetLowering::LowerArguments(Function &F, SelectionDAG &DAG) { // Add CC# and isVararg as operands to the FORMAL_ARGUMENTS node. std::vector Ops; + Ops.push_back(DAG.getRoot()); Ops.push_back(DAG.getConstant(F.getCallingConv(), getPointerTy())); Ops.push_back(DAG.getConstant(F.isVarArg(), getPointerTy())); @@ -2393,11 +2394,12 @@ TargetLowering::LowerArguments(Function &F, SelectionDAG &DAG) { } } - if (RetVals.size() == 0) - RetVals.push_back(MVT::isVoid); + RetVals.push_back(MVT::Other); // Create the node. SDNode *Result = DAG.getNode(ISD::FORMAL_ARGUMENTS, RetVals, Ops).Val; + + DAG.setRoot(SDOperand(Result, Result->getNumValues()-1)); // Set up the return result vector. Ops.clear(); diff --git a/lib/Target/X86/X86ISelLowering.cpp b/lib/Target/X86/X86ISelLowering.cpp index 9962aeac7e9..8fc591b5d1b 100644 --- a/lib/Target/X86/X86ISelLowering.cpp +++ b/lib/Target/X86/X86ISelLowering.cpp @@ -365,8 +365,8 @@ X86TargetLowering::LowerArguments(Function &F, SelectionDAG &DAG) { FormalArgs.clear(); FormalArgLocs.clear(); - // This sets BytesToPopOnReturn, BytesCallerReserves, etc. which have to be set - // before the rest of the function can be lowered. + // This sets BytesToPopOnReturn, BytesCallerReserves, etc. which have to be + // set before the rest of the function can be lowered. if (F.getCallingConv() == CallingConv::Fast && EnableFastCC) PreprocessFastCCArguments(Args, F, DAG); else @@ -522,14 +522,15 @@ void X86TargetLowering::PreprocessCCCArguments(std::vectorArgs, } void X86TargetLowering::LowerCCCArguments(SDOperand Op, SelectionDAG &DAG) { - unsigned NumArgs = Op.Val->getNumValues(); + unsigned NumArgs = Op.Val->getNumValues() - 1; MachineFunction &MF = DAG.getMachineFunction(); for (unsigned i = 0; i < NumArgs; ++i) { std::pair Loc = FormalArgLocs[i]; SDOperand ArgValue; if (Loc.first.Kind == FALocInfo::StackFrameLoc) { - // Create the SelectionDAG nodes corresponding to a load from this parameter + // Create the SelectionDAG nodes corresponding to a load from this + // parameter. unsigned FI = FormalArgLocs[i].first.Loc; SDOperand FIN = DAG.getFrameIndex(FI, MVT::i32); ArgValue = DAG.getLoad(Op.Val->getValueType(i), @@ -676,7 +677,8 @@ X86TargetLowering::LowerCCCCallTo(SDOperand Chain, const Type *RetTy, unsigned CCReg = XMMArgRegs[i]; SDOperand RegToPass = RegValuesToPass[i]; assert(RegToPass.getValueType() == MVT::Vector); - unsigned NumElems = cast(*(RegToPass.Val->op_end()-2))->getValue(); + unsigned NumElems = + cast(*(RegToPass.Val->op_end()-2))->getValue(); MVT::ValueType EVT = cast(*(RegToPass.Val->op_end()-1))->getVT(); MVT::ValueType PVT = getVectorType(EVT, NumElems); SDOperand CCRegNode = DAG.getRegister(CCReg, PVT); @@ -1043,7 +1045,7 @@ X86TargetLowering::PreprocessFastCCArguments(std::vectorArgs, void X86TargetLowering::LowerFastCCArguments(SDOperand Op, SelectionDAG &DAG) { - unsigned NumArgs = Op.Val->getNumValues(); + unsigned NumArgs = Op.Val->getNumValues()-1; MachineFunction &MF = DAG.getMachineFunction(); for (unsigned i = 0; i < NumArgs; ++i) { @@ -1051,9 +1053,10 @@ X86TargetLowering::LowerFastCCArguments(SDOperand Op, SelectionDAG &DAG) { std::pair Loc = FormalArgLocs[i]; SDOperand ArgValue; if (Loc.first.Kind == FALocInfo::StackFrameLoc) { - // Create the SelectionDAG nodes corresponding to a load from this parameter + // Create the SelectionDAG nodes corresponding to a load from this + // parameter. SDOperand FIN = DAG.getFrameIndex(Loc.first.Loc, MVT::i32); - ArgValue = DAG.getLoad(Op.Val->getValueType(i),DAG.getEntryNode(), FIN, + ArgValue = DAG.getLoad(Op.Val->getValueType(i), DAG.getEntryNode(), FIN, DAG.getSrcValue(NULL)); } else { // Must be a CopyFromReg @@ -1064,10 +1067,11 @@ X86TargetLowering::LowerFastCCArguments(SDOperand Op, SelectionDAG &DAG) { if (Loc.second.Kind != FALocInfo::None) { SDOperand ArgValue2; if (Loc.second.Kind == FALocInfo::StackFrameLoc) { - // Create the SelectionDAG nodes corresponding to a load from this parameter + // Create the SelectionDAG nodes corresponding to a load from this + // parameter. SDOperand FIN = DAG.getFrameIndex(Loc.second.Loc, MVT::i32); - ArgValue2 = DAG.getLoad(Op.Val->getValueType(i),DAG.getEntryNode(), FIN, - DAG.getSrcValue(NULL)); + ArgValue2 = DAG.getLoad(Op.Val->getValueType(i), DAG.getEntryNode(), + FIN, DAG.getSrcValue(NULL)); } else { // Must be a CopyFromReg ArgValue2 = DAG.getCopyFromReg(DAG.getEntryNode(), @@ -1263,7 +1267,8 @@ X86TargetLowering::LowerFastCCCallTo(SDOperand Chain, const Type *RetTy, Ops.push_back(InFlag); // FIXME: Do not generate X86ISD::TAILCALL for now. - Chain = DAG.getNode(isTailCall ? X86ISD::TAILCALL : X86ISD::CALL, NodeTys, Ops); + Chain = DAG.getNode(isTailCall ? X86ISD::TAILCALL : X86ISD::CALL, + NodeTys, Ops); InFlag = Chain.getValue(1); NodeTys.clear(); @@ -2812,10 +2817,12 @@ X86TargetLowering::LowerVECTOR_SHUFFLE(SDOperand Op, SelectionDAG &DAG) { } } - SDOperand LoShuffle = DAG.getNode(ISD::VECTOR_SHUFFLE, VT, V1, V2, - DAG.getNode(ISD::BUILD_VECTOR, MaskVT, LoMask)); - SDOperand HiShuffle = DAG.getNode(ISD::VECTOR_SHUFFLE, VT, V1, V2, - DAG.getNode(ISD::BUILD_VECTOR, MaskVT, HiMask)); + SDOperand LoShuffle = + DAG.getNode(ISD::VECTOR_SHUFFLE, VT, V1, V2, + DAG.getNode(ISD::BUILD_VECTOR, MaskVT, LoMask)); + SDOperand HiShuffle = + DAG.getNode(ISD::VECTOR_SHUFFLE, VT, V1, V2, + DAG.getNode(ISD::BUILD_VECTOR, MaskVT, HiMask)); std::vector MaskOps; for (unsigned i = 0; i != NumElems; ++i) { if (Locs[i].first == -1) { @@ -2978,12 +2985,14 @@ SDOperand X86TargetLowering::LowerGlobalAddress(SDOperand Op, SelectionDAG &DAG) { GlobalValue *GV = cast(Op)->getGlobal(); SDOperand Result = DAG.getNode(X86ISD::Wrapper, getPointerTy(), - DAG.getTargetGlobalAddress(GV, getPointerTy())); + DAG.getTargetGlobalAddress(GV, + getPointerTy())); if (Subtarget->isTargetDarwin()) { // With PIC, the address is actually $g + Offset. if (getTargetMachine().getRelocationModel() == Reloc::PIC) Result = DAG.getNode(ISD::ADD, getPointerTy(), - DAG.getNode(X86ISD::GlobalBaseReg, getPointerTy()), Result); + DAG.getNode(X86ISD::GlobalBaseReg, getPointerTy()), + Result); // For Darwin, external and weak symbols are indirect, so we want to load // the value at address GV, not the value of GV itself. This means that @@ -3002,12 +3011,14 @@ SDOperand X86TargetLowering::LowerExternalSymbol(SDOperand Op, SelectionDAG &DAG) { const char *Sym = cast(Op)->getSymbol(); SDOperand Result = DAG.getNode(X86ISD::Wrapper, getPointerTy(), - DAG.getTargetExternalSymbol(Sym, getPointerTy())); + DAG.getTargetExternalSymbol(Sym, + getPointerTy())); if (Subtarget->isTargetDarwin()) { // With PIC, the address is actually $g + Offset. if (getTargetMachine().getRelocationModel() == Reloc::PIC) Result = DAG.getNode(ISD::ADD, getPointerTy(), - DAG.getNode(X86ISD::GlobalBaseReg, getPointerTy()), Result); + DAG.getNode(X86ISD::GlobalBaseReg, getPointerTy()), + Result); } return Result; @@ -3391,7 +3402,8 @@ SDOperand X86TargetLowering::LowerJumpTable(SDOperand Op, SelectionDAG &DAG) { // With PIC, the address is actually $g + Offset. if (getTargetMachine().getRelocationModel() == Reloc::PIC) Result = DAG.getNode(ISD::ADD, getPointerTy(), - DAG.getNode(X86ISD::GlobalBaseReg, getPointerTy()), Result); + DAG.getNode(X86ISD::GlobalBaseReg, getPointerTy()), + Result); } return Result; @@ -3494,7 +3506,7 @@ SDOperand X86TargetLowering::LowerRET(SDOperand Op, SelectionDAG &DAG) { SDOperand X86TargetLowering::LowerFORMAL_ARGUMENTS(SDOperand Op, SelectionDAG &DAG) { if (FormalArgs.size() == 0) { - unsigned CC = cast(Op.getOperand(0))->getValue(); + unsigned CC = cast(Op.getOperand(1))->getValue(); if (CC == CallingConv::Fast && EnableFastCC) LowerFastCCArguments(Op, DAG); else