From: Jakob Stoklund Olesen Date: Fri, 6 Jul 2012 02:31:22 +0000 (+0000) Subject: Add some comments suggested in code review. X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=86fc3100b552c8d400160581c2a00f2fd7b83b45;p=oota-llvm.git Add some comments suggested in code review. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159800 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/EarlyIfConversion.cpp b/lib/CodeGen/EarlyIfConversion.cpp index f575b249aa1..effddfbbad2 100644 --- a/lib/CodeGen/EarlyIfConversion.cpp +++ b/lib/CodeGen/EarlyIfConversion.cpp @@ -167,6 +167,9 @@ bool SSAIfConv::canSpeculateInstrs(MachineBasicBlock *MBB) { } unsigned InstrCount = 0; + + // Check all instructions, except the terminators. It is assumed that + // terminators never have side effects or define any used register values. for (MachineBasicBlock::iterator I = MBB->begin(), E = MBB->getFirstTerminator(); I != E; ++I) { if (I->isDebugValue()) @@ -569,11 +572,15 @@ bool EarlyIfConverter::runOnMachineFunction(MachineFunction &MF) { bool Changed = false; IfConv.runOnMachineFunction(MF); + // Initially visit blocks in layout order. The tryConvertIf() function may + // erase blocks, but never the head block passed as MFI. for (MachineFunction::iterator MFI = MF.begin(), MFE = MF.end(); MFI != MFE; ++MFI) if (tryConvertIf(MFI)) Changed = true; + // Revisit blocks identified by tryConvertIf() as candidates for nested + // if-conversion. DEBUG(dbgs() << "Revisiting " << WorkList.size() << " blocks.\n"); while (!WorkList.empty()) tryConvertIf(WorkList.pop_back_val());