From: Christopher Dykes <cdykes@fb.com>
Date: Tue, 29 Nov 2016 05:23:33 +0000 (-0800)
Subject: Use std::terminate rather than throwing in a noexcept function
X-Git-Tag: v2016.12.05.00~16
X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=82e1b57979015eaf3630def3ec1cebeef6bcdafa;p=folly.git

Use std::terminate rather than throwing in a noexcept function

Summary: Because MSVC isn't happy about it and generates a warning with a lot of context.

Reviewed By: yfeldblum

Differential Revision: D4242688

fbshipit-source-id: b1e26c9e3b58e7bac0e00ab8959358010fa610e8
---

diff --git a/folly/ScopeGuard.h b/folly/ScopeGuard.h
index 26531cd8..2c71c5b9 100644
--- a/folly/ScopeGuard.h
+++ b/folly/ScopeGuard.h
@@ -83,7 +83,7 @@ class ScopeGuardImplBase {
       function();
     } catch (...) {
       warnAboutToCrash();
-      throw;
+      std::terminate();
     }
   }