From: David S. Miller <davem@davemloft.net>
Date: Sun, 17 Apr 2011 23:48:53 +0000 (-0700)
Subject: isdn: mISDN: socket: Fix set-but-unused variables.
X-Git-Tag: firefly_0821_release~3680^2~5008^2~513
X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=81b424d9e2ef815b2035d4c2be0bc41dddbebc06;p=firefly-linux-kernel-4.4.55.git

isdn: mISDN: socket: Fix set-but-unused variables.

The variable 'len' is set but unused in data_sock_getsockopt().

The code should use 'len' to validate that the user's socket option is
indeed the right size.

Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/isdn/mISDN/socket.c b/drivers/isdn/mISDN/socket.c
index 7446d8b4282d..8e325227b4c0 100644
--- a/drivers/isdn/mISDN/socket.c
+++ b/drivers/isdn/mISDN/socket.c
@@ -457,6 +457,9 @@ static int data_sock_getsockopt(struct socket *sock, int level, int optname,
 	if (get_user(len, optlen))
 		return -EFAULT;
 
+	if (len != sizeof(char))
+		return -EINVAL;
+
 	switch (optname) {
 	case MISDN_TIME_STAMP:
 		if (_pms(sk)->cmask & MISDN_TIME_STAMP)