From: Gabor Greif Date: Sat, 17 Jan 2009 00:14:25 +0000 (+0000) Subject: speed up iterative loop by using iterators. changes direction, but functionally equiv... X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=7b98424f719bf0bde6250e35d311e877d6c3d5b7;p=oota-llvm.git speed up iterative loop by using iterators. changes direction, but functionally equivalent if this works out, I'll change the others next. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@62385 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Analysis/IPA/CallGraph.cpp b/lib/Analysis/IPA/CallGraph.cpp index c1082a00280..b459246c298 100644 --- a/lib/Analysis/IPA/CallGraph.cpp +++ b/lib/Analysis/IPA/CallGraph.cpp @@ -260,10 +260,10 @@ void CallGraphNode::dump() const { print(cerr); } /// specified call site. Note that this method takes linear time, so it /// should be used sparingly. void CallGraphNode::removeCallEdgeFor(CallSite CS) { - for (unsigned i = CalledFunctions.size(); ; --i) { - assert(i && "Cannot find callsite to remove!"); - if (CalledFunctions[i-1].first == CS) { - CalledFunctions.erase(CalledFunctions.begin()+i-1); + for (CalledFunctionsVector::iterator I = CalledFunctions.begin(); ; ++I) { + assert(I != CalledFunctions.end() && "Cannot find callsite to remove!"); + if (I->first == CS) { + CalledFunctions.erase(I); return; } }