From: Duncan Sands <baldrick@free.fr>
Date: Wed, 5 Dec 2007 21:03:28 +0000 (+0000)
Subject: Commit 44487 broke bootstrap of llvm-gcc-4.2.  It is
X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=5d84afdc836fa28d840449108206e850617a2a15;p=oota-llvm.git

Commit 44487 broke bootstrap of llvm-gcc-4.2.  It is
not yet clear why, but in the meantime work around the
problem by making less use of readnone/readonly info.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@44626 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/AliasAnalysis.cpp b/lib/Analysis/AliasAnalysis.cpp
index 12ea937fa92..fe3f41a9ce8 100644
--- a/lib/Analysis/AliasAnalysis.cpp
+++ b/lib/Analysis/AliasAnalysis.cpp
@@ -116,13 +116,17 @@ AliasAnalysis::getModRefInfo(StoreInst *S, Value *P, unsigned Size) {
 AliasAnalysis::ModRefBehavior
 AliasAnalysis::getModRefBehavior(CallSite CS,
                                  std::vector<PointerAccessInfo> *Info) {
-  if (CS.doesNotAccessMemory())
+  if (CS.doesNotAccessMemory() &&
+      // FIXME: workaround gcc bootstrap breakage
+      CS.getCalledFunction() && CS.getCalledFunction()->isDeclaration())
     // Can't do better than this.
     return DoesNotAccessMemory;
   ModRefBehavior MRB = UnknownModRefBehavior;
   if (Function *F = CS.getCalledFunction())
     MRB = getModRefBehavior(F, CS, Info);
-  if (MRB != DoesNotAccessMemory && CS.onlyReadsMemory())
+  if (MRB != DoesNotAccessMemory && CS.onlyReadsMemory() &&
+      // FIXME: workaround gcc bootstrap breakage
+      CS.getCalledFunction() && CS.getCalledFunction()->isDeclaration())
     return OnlyReadsMemory;
   return MRB;
 }
@@ -130,11 +134,15 @@ AliasAnalysis::getModRefBehavior(CallSite CS,
 AliasAnalysis::ModRefBehavior
 AliasAnalysis::getModRefBehavior(Function *F,
                                  std::vector<PointerAccessInfo> *Info) {
-  if (F->doesNotAccessMemory())
+  if (F->doesNotAccessMemory() &&
+      // FIXME: workaround gcc bootstrap breakage
+      F->isDeclaration())
     // Can't do better than this.
     return DoesNotAccessMemory;
   ModRefBehavior MRB = getModRefBehavior(F, CallSite(), Info);
-  if (MRB != DoesNotAccessMemory && F->onlyReadsMemory())
+  if (MRB != DoesNotAccessMemory && F->onlyReadsMemory() &&
+      // FIXME: workaround gcc bootstrap breakage
+      F->isDeclaration())
     return OnlyReadsMemory;
   return MRB;
 }
diff --git a/lib/VMCore/Instruction.cpp b/lib/VMCore/Instruction.cpp
index 9b208854ba1..7fc6245f6da 100644
--- a/lib/VMCore/Instruction.cpp
+++ b/lib/VMCore/Instruction.cpp
@@ -13,6 +13,7 @@
 
 #include "llvm/Type.h"
 #include "llvm/Instructions.h"
+#include "llvm/IntrinsicInst.h" // FIXME: remove
 #include "llvm/Function.h"
 #include "llvm/Support/CallSite.h"
 #include "llvm/Support/LeakDetector.h"
@@ -208,6 +209,8 @@ bool Instruction::mayWriteToMemory() const {
   case Instruction::VAArg:
     return true;
   case Instruction::Call:
+    if (!isa<IntrinsicInst>(this))
+      return true; // FIXME: workaround gcc bootstrap breakage
     return !cast<CallInst>(this)->onlyReadsMemory();
   case Instruction::Load:
     return cast<LoadInst>(this)->isVolatile();