From: Dan Gohman <gohman@apple.com>
Date: Wed, 1 Oct 2008 02:02:03 +0000 (+0000)
Subject: Call ScalarEvolution's deleteValueFromRecords before deleting an
X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=586b7b75479990475ed5a03fae72d44e0b5ca8e7;p=oota-llvm.git

Call ScalarEvolution's deleteValueFromRecords before deleting an
instruction, not after. This fixes some uses of free'd memory.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@56908 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Transforms/Scalar/LoopStrengthReduce.cpp b/lib/Transforms/Scalar/LoopStrengthReduce.cpp
index 07438e30c71..30e86447f25 100644
--- a/lib/Transforms/Scalar/LoopStrengthReduce.cpp
+++ b/lib/Transforms/Scalar/LoopStrengthReduce.cpp
@@ -1803,15 +1803,15 @@ ICmpInst *LoopStrengthReduce::OptimizeSMax(Loop *L, ICmpInst *Cond,
                  Cond->getOperand(0), NewRHS, "scmp", Cond);
 
   // Delete the max calculation instructions.
+  SE->deleteValueFromRecords(Cond);
   Cond->replaceAllUsesWith(NewCond);
   Cond->eraseFromParent();
-  SE->deleteValueFromRecords(Cond);
   Instruction *Cmp = cast<Instruction>(Sel->getOperand(0));
-  Sel->eraseFromParent();
   SE->deleteValueFromRecords(Sel);
+  Sel->eraseFromParent();
   if (Cmp->use_empty()) {
-    Cmp->eraseFromParent();
     SE->deleteValueFromRecords(Cmp);
+    Cmp->eraseFromParent();
   }
   CondUse->User = NewCond;
   return NewCond;