From: Chandler Carruth <chandlerc@gmail.com>
Date: Mon, 17 Dec 2012 13:51:03 +0000 (+0000)
Subject: Hoist a convertValue call to the two paths where it is needed.
X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=5814a88ce9ebe415015b37477c841304fa8b7b1a;p=oota-llvm.git

Hoist a convertValue call to the two paths where it is needed.

I noticed this while looking at r170328. We only ever do a vector
rewrite when the alloca *is* the vector type, so it's good to not paper
over bugs here by doing a convertValue that isn't needed.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@170331 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Transforms/Scalar/SROA.cpp b/lib/Transforms/Scalar/SROA.cpp
index 01c7b421b28..ef16f46580b 100644
--- a/lib/Transforms/Scalar/SROA.cpp
+++ b/lib/Transforms/Scalar/SROA.cpp
@@ -2807,6 +2807,7 @@ private:
         assert(V->getType() == IntTy &&
                "Wrong type for an alloca wide integer!");
       }
+      V = convertValue(TD, IRB, V, AllocaTy);
     } else {
       // Established these invariants above.
       assert(BeginOffset == NewAllocaBeginOffset);
@@ -2814,13 +2815,13 @@ private:
 
       V = getIntegerSplat(IRB, II.getValue(),
                           TD.getTypeSizeInBits(ScalarTy)/8);
-
       if (VectorType *AllocaVecTy = dyn_cast<VectorType>(AllocaTy))
         V = getVectorSplat(IRB, V, AllocaVecTy->getNumElements());
+
+      V = convertValue(TD, IRB, V, AllocaTy);
     }
 
-    Value *New = IRB.CreateAlignedStore(convertValue(TD, IRB, V, AllocaTy),
-                                        &NewAI, NewAI.getAlignment(),
+    Value *New = IRB.CreateAlignedStore(V, &NewAI, NewAI.getAlignment(),
                                         II.isVolatile());
     (void)New;
     DEBUG(dbgs() << "          to: " << *New << "\n");