From: Reid Spencer Date: Fri, 19 Nov 2004 03:44:10 +0000 (+0000) Subject: Don't save an iterator, just use post-increment. X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=57646ec44eb2ff59b99c3b5e4fe0e5084462b2f3;p=oota-llvm.git Don't save an iterator, just use post-increment. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@17981 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Archive/ArchiveReader.cpp b/lib/Archive/ArchiveReader.cpp index 6f5b9d36edf..c0f0d1569bd 100644 --- a/lib/Archive/ArchiveReader.cpp +++ b/lib/Archive/ArchiveReader.cpp @@ -472,10 +472,8 @@ Archive::findModulesDefiningSymbols(std::set& symbols, result.insert(mp); // Remove the symbol now that its been resolved, being careful to - // not invalidate our iterator. - std::set::iterator save = I; - ++I; - symbols.erase(save); + // post-increment the iterator. + symbols.erase(I++); } else { ++I; } diff --git a/lib/Bytecode/Archive/ArchiveReader.cpp b/lib/Bytecode/Archive/ArchiveReader.cpp index 6f5b9d36edf..c0f0d1569bd 100644 --- a/lib/Bytecode/Archive/ArchiveReader.cpp +++ b/lib/Bytecode/Archive/ArchiveReader.cpp @@ -472,10 +472,8 @@ Archive::findModulesDefiningSymbols(std::set& symbols, result.insert(mp); // Remove the symbol now that its been resolved, being careful to - // not invalidate our iterator. - std::set::iterator save = I; - ++I; - symbols.erase(save); + // post-increment the iterator. + symbols.erase(I++); } else { ++I; }