From: Eli Friedman Date: Fri, 24 Jul 2009 21:56:17 +0000 (+0000) Subject: Fix assert assembling zero-argument constant GEP. X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=4e9bac3769cb668aad20f1ac2d6a35d9ba452f3a;p=oota-llvm.git Fix assert assembling zero-argument constant GEP. There's still a strict-aliasing violation here, but I don't feel like dealing with that right now... git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@77005 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/AsmParser/LLParser.cpp b/lib/AsmParser/LLParser.cpp index 94224a6361c..45e70c8f9c8 100644 --- a/lib/AsmParser/LLParser.cpp +++ b/lib/AsmParser/LLParser.cpp @@ -2017,10 +2017,11 @@ bool LLParser::ParseValID(ValID &ID) { return Error(ID.Loc, "getelementptr requires pointer operand"); if (!GetElementPtrInst::getIndexedType(Elts[0]->getType(), - (Value**)&Elts[1], Elts.size()-1)) + (Value**)(Elts.data() + 1), + Elts.size() - 1)) return Error(ID.Loc, "invalid indices for getelementptr"); ID.ConstantVal = Context.getConstantExprGetElementPtr(Elts[0], - &Elts[1], Elts.size()-1); + Elts.data() + 1, Elts.size() - 1); } else if (Opc == Instruction::Select) { if (Elts.size() != 3) return Error(ID.Loc, "expected three operands to select"); diff --git a/test/Assembler/2009-07-24-ZeroArgGEP.ll b/test/Assembler/2009-07-24-ZeroArgGEP.ll new file mode 100644 index 00000000000..ce4a9614861 --- /dev/null +++ b/test/Assembler/2009-07-24-ZeroArgGEP.ll @@ -0,0 +1,5 @@ +; RUN: llvm-as %s -o /dev/null -f + +@foo = global i32 0 +@bar = constant i32* getelementptr(i32* @foo) +