From: Salva Peiró Date: Wed, 14 Oct 2015 15:48:02 +0000 (+0200) Subject: staging/dgnc: fix info leak in ioctl X-Git-Tag: firefly_0821_release~176^2~802^2~570 X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=4b6184336ebb5c8dc1eae7f7ab46ee608a748b05;p=firefly-linux-kernel-4.4.55.git staging/dgnc: fix info leak in ioctl The dgnc_mgmt_ioctl() code fails to initialize the 16 _reserved bytes of struct digi_dinfo after the ->dinfo_nboards member. Add an explicit memset(0) before filling the structure to avoid the info leak. Signed-off-by: Salva Peiró Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c index 9ec3efe0a287..518fbd5e2d0e 100644 --- a/drivers/staging/dgnc/dgnc_mgmt.c +++ b/drivers/staging/dgnc/dgnc_mgmt.c @@ -110,6 +110,7 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg) spin_lock_irqsave(&dgnc_global_lock, flags); + memset(&ddi, 0, sizeof(ddi)); ddi.dinfo_nboards = dgnc_NumBoards; sprintf(ddi.dinfo_version, "%s", DG_PART);