From: Hannes Roth <hannesr@fb.com>
Date: Thu, 6 Mar 2014 01:39:47 +0000 (-0800)
Subject: (Wangle) Remove some early returns in tests
X-Git-Tag: v0.22.0~657
X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=44c12101e5a6e85e1ecf7f9f402bac30891f61fb;p=folly.git

(Wangle) Remove some early returns in tests

Summary:
I guess they sneaked in when testing.

Also remove an `EXPECT_NE` that depended on `std::move` actually moving.

Test Plan: All the tests.

Reviewed By: hans@fb.com

FB internal diff: D1204971
---

diff --git a/folly/wangle/test/FutureTest.cpp b/folly/wangle/test/FutureTest.cpp
index e356d0de..e5906058 100644
--- a/folly/wangle/test/FutureTest.cpp
+++ b/folly/wangle/test/FutureTest.cpp
@@ -171,14 +171,10 @@ TEST(Promise, setValue) {
 
   pod = Promise<Foo>();
   fpod = pod.getFuture();
-  return;
   pod.setValue(std::move(f2));
   Foo f3 = fpod.value();
   EXPECT_EQ(f.name, f3.name);
   EXPECT_EQ(f.value, f3.value);
-  EXPECT_NE(f.name, f2.name);
-
-  return;
 
   Promise<unique_ptr<int>> mov;
   auto fmov = mov.getFuture();