From: David Majnemer Date: Mon, 7 Oct 2013 21:57:07 +0000 (+0000) Subject: Windows: Avoiding resizing, use uninitialized data() instead X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=34e1444ebde9516422f08d8ddb4358b11b7e50c1;p=oota-llvm.git Windows: Avoiding resizing, use uninitialized data() instead This is ever-so faster but more importantly matches what we have elsewhere. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@192137 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Support/Windows/Process.inc b/lib/Support/Windows/Process.inc index 50a204fe5fa..f9a3db9d918 100644 --- a/lib/Support/Windows/Process.inc +++ b/lib/Support/Windows/Process.inc @@ -161,8 +161,9 @@ Optional Process::GetEnv(StringRef Name) { SmallVector Buf; size_t Size = MAX_PATH; do { - Buf.resize(Size); - Size = GetEnvironmentVariableW(&NameUTF16[0], &Buf[0], Buf.capacity()); + Buf.reserve(Size); + Size = + GetEnvironmentVariableW(NameUTF16.data(), Buf.data(), Buf.capacity()); if (Size == 0) return None; @@ -172,9 +173,9 @@ Optional Process::GetEnv(StringRef Name) { // Convert the result from UTF-16 to UTF-8. SmallVector Res; - if (error_code ec = windows::UTF16ToUTF8(&Buf[0], Size, Res)) + if (error_code ec = windows::UTF16ToUTF8(Buf.data(), Size, Res)) return None; - return std::string(&Res[0]); + return std::string(Res.data()); } error_code