From: Chris Lattner <sabre@nondot.org>
Date: Sun, 14 Mar 2004 04:01:06 +0000 (+0000)
Subject: FunctionPass's should not define their own 'run' method.
X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=16d0eb04688d283dc70a8f4a9905cb19d8636cd2;p=oota-llvm.git

FunctionPass's should not define their own 'run' method.
Require 'simplified' loops, not just raw natural loops.  This fixes
CodeExtractor/2004-03-13-LoopExtractorCrash.ll


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@12381 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Transforms/IPO/LoopExtractor.cpp b/lib/Transforms/IPO/LoopExtractor.cpp
index 3aa5686b210..5e7dbc66145 100644
--- a/lib/Transforms/IPO/LoopExtractor.cpp
+++ b/lib/Transforms/IPO/LoopExtractor.cpp
@@ -18,17 +18,18 @@
 #include "llvm/Module.h"
 #include "llvm/Pass.h"
 #include "llvm/Analysis/LoopInfo.h"
+#include "llvm/Transforms/Scalar.h"
 #include "llvm/Transforms/Utils/FunctionUtils.h"
 using namespace llvm;
 
 namespace {
   // FIXME: PassManager should allow Module passes to require FunctionPasses
   struct LoopExtractor : public FunctionPass {
-    virtual bool run(Module &M);
     virtual bool runOnFunction(Function &F);
     
     virtual void getAnalysisUsage(AnalysisUsage &AU) const {
       AU.addRequired<LoopInfo>();
+      AU.addRequiredID(LoopSimplifyID);
     }
   };
 
@@ -36,13 +37,6 @@ namespace {
   X("loop-extract", "Extract loops into new functions");
 } // End anonymous namespace 
 
-bool LoopExtractor::run(Module &M) {
-  bool Changed = false;
-  for (Module::iterator i = M.begin(), e = M.end(); i != e; ++i)
-    Changed |= runOnFunction(*i);
-  return Changed;
-}
-
 bool LoopExtractor::runOnFunction(Function &F) {
   std::cerr << F.getName() << "\n";