From: Evan Cheng Date: Wed, 19 Jul 2006 00:27:29 +0000 (+0000) Subject: INC / DEC instructions have shorter code size than ADD32ri8, etc. X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=1693e489e6f8935ca9b42ba7c06e684df6395fee;p=oota-llvm.git INC / DEC instructions have shorter code size than ADD32ri8, etc. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@29194 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Target/X86/X86InstrInfo.td b/lib/Target/X86/X86InstrInfo.td index 5fa7be74903..9d478f5ef74 100644 --- a/lib/Target/X86/X86InstrInfo.td +++ b/lib/Target/X86/X86InstrInfo.td @@ -314,18 +314,22 @@ def extloadi32i16 : PatFrag<(ops node:$ptr), (i32 (extload node:$ptr, i16))>; class I o, Format f, dag ops, string asm, list pattern> : X86Inst { let Pattern = pattern; + let CodeSize = 3; } class Ii8 o, Format f, dag ops, string asm, list pattern> : X86Inst { let Pattern = pattern; + let CodeSize = 3; } class Ii16 o, Format f, dag ops, string asm, list pattern> : X86Inst { let Pattern = pattern; + let CodeSize = 3; } class Ii32 o, Format f, dag ops, string asm, list pattern> : X86Inst { let Pattern = pattern; + let CodeSize = 3; } //===----------------------------------------------------------------------===// @@ -1060,6 +1064,7 @@ def CMOVNP32rm : I<0x4B, MRMSrcMem, // if !parity, GR32 = [mem32] // unary instructions +let CodeSize = 2 in { def NEG8r : I<0xF6, MRM3r, (ops GR8 :$dst, GR8 :$src), "neg{b} $dst", [(set GR8:$dst, (ineg GR8:$src))]>; def NEG16r : I<0xF7, MRM3r, (ops GR16:$dst, GR16:$src), "neg{w} $dst", @@ -1090,17 +1095,19 @@ let isTwoAddress = 0 in { def NOT32m : I<0xF7, MRM2m, (ops i32mem:$dst), "not{l} $dst", [(store (not (loadi32 addr:$dst)), addr:$dst)]>; } +} // CodeSize // TODO: inc/dec is slow for P4, but fast for Pentium-M. +let CodeSize = 2 in def INC8r : I<0xFE, MRM0r, (ops GR8 :$dst, GR8 :$src), "inc{b} $dst", [(set GR8:$dst, (add GR8:$src, 1))]>; -let isConvertibleToThreeAddress = 1 in { // Can transform into LEA. +let isConvertibleToThreeAddress = 1, CodeSize = 1 in { // Can xform into LEA. def INC16r : I<0x40, AddRegFrm, (ops GR16:$dst, GR16:$src), "inc{w} $dst", [(set GR16:$dst, (add GR16:$src, 1))]>, OpSize; def INC32r : I<0x40, AddRegFrm, (ops GR32:$dst, GR32:$src), "inc{l} $dst", [(set GR32:$dst, (add GR32:$src, 1))]>; } -let isTwoAddress = 0 in { +let isTwoAddress = 0, CodeSize = 2 in { def INC8m : I<0xFE, MRM0m, (ops i8mem :$dst), "inc{b} $dst", [(store (add (loadi8 addr:$dst), 1), addr:$dst)]>; def INC16m : I<0xFF, MRM0m, (ops i16mem:$dst), "inc{w} $dst", @@ -1109,16 +1116,17 @@ let isTwoAddress = 0 in { [(store (add (loadi32 addr:$dst), 1), addr:$dst)]>; } +let CodeSize = 2 in def DEC8r : I<0xFE, MRM1r, (ops GR8 :$dst, GR8 :$src), "dec{b} $dst", [(set GR8:$dst, (add GR8:$src, -1))]>; -let isConvertibleToThreeAddress = 1 in { // Can transform into LEA. +let isConvertibleToThreeAddress = 1, CodeSize = 1 in { // Can xform into LEA. def DEC16r : I<0x48, AddRegFrm, (ops GR16:$dst, GR16:$src), "dec{w} $dst", [(set GR16:$dst, (add GR16:$src, -1))]>, OpSize; def DEC32r : I<0x48, AddRegFrm, (ops GR32:$dst, GR32:$src), "dec{l} $dst", [(set GR32:$dst, (add GR32:$src, -1))]>; } -let isTwoAddress = 0 in { +let isTwoAddress = 0, CodeSize = 2 in { def DEC8m : I<0xFE, MRM1m, (ops i8mem :$dst), "dec{b} $dst", [(store (add (loadi8 addr:$dst), -1), addr:$dst)]>; def DEC16m : I<0xFF, MRM1m, (ops i16mem:$dst), "dec{w} $dst", diff --git a/lib/Target/X86/X86InstrMMX.td b/lib/Target/X86/X86InstrMMX.td index 361b6ab1508..104d87976a9 100644 --- a/lib/Target/X86/X86InstrMMX.td +++ b/lib/Target/X86/X86InstrMMX.td @@ -22,9 +22,7 @@ class MMXI o, Format F, dag ops, string asm, list pattern> class MMX2I o, Format F, dag ops, string asm, list pattern> : I, TB, OpSize, Requires<[HasSSE2]>; class MMXIi8 o, Format F, dag ops, string asm, list pattern> - : X86Inst, TB, Requires<[HasMMX]> { - let Pattern = pattern; -} + : Ii8, TB, Requires<[HasMMX]>; // Some 'special' instructions def IMPLICIT_DEF_VR64 : I<0, Pseudo, (ops VR64:$dst),