From: David Blaikie <dblaikie@gmail.com>
Date: Tue, 1 Apr 2014 22:25:09 +0000 (+0000)
Subject: Fix accidental fallthrough in DebugLocEntry::hasSameValueOrLocation
X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=0afa71ea9154331eac03b1418b3fbf6127be9e95;p=oota-llvm.git

Fix accidental fallthrough in DebugLocEntry::hasSameValueOrLocation

No test case (this would invoke UB by examining uninitialized members,
etc, at best - and this code is apparently untested anyway - I'm about
to fix that)

Code review feedback from Adrian Prantl on r205360.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@205367 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/CodeGen/AsmPrinter/DebugLocEntry.h b/lib/CodeGen/AsmPrinter/DebugLocEntry.h
index 9f5be6164f5..976edf0a2ab 100644
--- a/lib/CodeGen/AsmPrinter/DebugLocEntry.h
+++ b/lib/CodeGen/AsmPrinter/DebugLocEntry.h
@@ -46,18 +46,23 @@ class DebugLocEntry {
     if (EntryKind != Next.EntryKind)
       return false;
 
+    bool EqualValues;
     switch (EntryKind) {
     case E_Location:
-      if (Loc != Next.Loc) return false;
+      EqualValues = Loc == Next.Loc;
+      break;
     case E_Integer:
-      if (Constants.Int != Next.Constants.Int) return false;
+      EqualValues = Constants.Int == Next.Constants.Int;
+      break;
     case E_ConstantFP:
-      if (Constants.CFP != Next.Constants.CFP) return false;
+      EqualValues = Constants.CFP == Next.Constants.CFP;
+      break;
     case E_ConstantInt:
-      if (Constants.CIP != Next.Constants.CIP) return false;
+      EqualValues = Constants.CIP == Next.Constants.CIP;
+      break;
     }
 
-    return true;
+    return EqualValues;
   }
 
 public: