From: Chanwoo Choi Date: Mon, 18 Jul 2016 06:39:28 +0000 (+0900) Subject: UPSTREAM: extcon: Remove the state_store() to prevent the wrong access X-Git-Tag: firefly_0821_release~2016 X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=0a5e7cc10c83976c466dd4b3939bd34724cd5e02;p=firefly-linux-kernel-4.4.55.git UPSTREAM: extcon: Remove the state_store() to prevent the wrong access This patch removes the state_store() which change the state of external connectors with bit masking on user-space. It is wrong access to modify the change the state of external connectors. Change-Id: I635e30e2a22ddc313ed90dc7ab0f7fdaa271ed1d Signed-off-by: Chanwoo Choi Signed-off-by: Chris Zhong (cherry picked from commit eeb820116207aa5dd71edbc0b8f0eaf3b20d77a1) --- diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 540f7a0b0559..9c7bd53a9f65 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -174,26 +174,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr, return count; } - -static ssize_t state_store(struct device *dev, struct device_attribute *attr, - const char *buf, size_t count) -{ - u32 state; - ssize_t ret = 0; - struct extcon_dev *edev = dev_get_drvdata(dev); - - ret = sscanf(buf, "0x%x", &state); - if (ret == 0) - ret = -EINVAL; - else - ret = extcon_set_state(edev, state); - - if (ret < 0) - return ret; - - return count; -} -static DEVICE_ATTR_RW(state); +static DEVICE_ATTR_RO(state); static ssize_t name_show(struct device *dev, struct device_attribute *attr, char *buf)