From: Markus Elfring Date: Tue, 2 Dec 2014 17:34:45 +0000 (+0100) Subject: ALSA: echoaudio: Deletion of a check before release_and_free_resource() X-Git-Tag: firefly_0821_release~176^2~2610^2~39^2~9 X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=057a4a55e703038d22bc9f2bcf8b02dc35850e16;p=firefly-linux-kernel-4.4.55.git ALSA: echoaudio: Deletion of a check before release_and_free_resource() The release_and_free_resource() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c index 60e40034b991..21228adaa70c 100644 --- a/sound/pci/echoaudio/echoaudio.c +++ b/sound/pci/echoaudio/echoaudio.c @@ -1875,8 +1875,7 @@ static int snd_echo_free(struct echoaudio *chip) if (chip->dsp_registers) iounmap(chip->dsp_registers); - if (chip->iores) - release_and_free_resource(chip->iores); + release_and_free_resource(chip->iores); pci_disable_device(chip->pci);