ixgbevf: Drop netdev_registered value since that is already stored in netdev
authorAlexander Duyck <alexander.h.duyck@intel.com>
Fri, 11 May 2012 08:32:24 +0000 (08:32 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 17 Jul 2012 09:46:03 +0000 (02:46 -0700)
There is no need to keep a separate netdev_registered value since that is
already stored in the netdev itself.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Acked-by: Greg Rose <gregory.v.rose@intel.com>
Tested-by: Sibai Li <sibai.li@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c

index 0cbce49672d06966be46d68b13c43773b37f637c..ed19f7e378a23a0d50d442aec14d74d71d5a0228 100644 (file)
@@ -231,7 +231,6 @@ struct ixgbevf_adapter {
        bool link_up;
 
        struct work_struct watchdog_task;
-       bool netdev_registered;
 };
 
 enum ixbgevf_state_t {
index 31327711c89e9721fe3d3d175c95a9721ef925ec..3cd865110a1aa72cb23c4d1ea47ce3b045d0907e 100644 (file)
@@ -3297,8 +3297,6 @@ static int __devinit ixgbevf_probe(struct pci_dev *pdev,
        if (err)
                goto err_register;
 
-       adapter->netdev_registered = true;
-
        netif_carrier_off(netdev);
 
        ixgbevf_init_last_counter_stats(adapter);
@@ -3347,10 +3345,8 @@ static void __devexit ixgbevf_remove(struct pci_dev *pdev)
        cancel_work_sync(&adapter->reset_task);
        cancel_work_sync(&adapter->watchdog_task);
 
-       if (adapter->netdev_registered) {
+       if (netdev->reg_state == NETREG_REGISTERED)
                unregister_netdev(netdev);
-               adapter->netdev_registered = false;
-       }
 
        ixgbevf_reset_interrupt_capability(adapter);