projects
/
firefly-linux-kernel-4.4.55.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
06fc222
)
applicom: dereferencing NULL on error path
author
Dan Carpenter
<dan.carpenter@oracle.com>
Fri, 9 May 2014 11:59:16 +0000
(14:59 +0300)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Tue, 1 Jul 2014 03:09:41 +0000
(20:09 -0700)
commit
8bab797c6e5724a43b7666ad70860712365cdb71
upstream.
This is a static checker fix. The "dev" variable is always NULL after
the while statement so we would be dereferencing a NULL pointer here.
Fixes: 819a3eba4233 ('[PATCH] applicom: fix error handling')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/applicom.c
patch
|
blob
|
history
diff --git
a/drivers/char/applicom.c
b/drivers/char/applicom.c
index 974321a2508d861655d1883480a902476ccc7a58..14790304b84b23fc2f8dfe4b23eeb9f659755d92 100644
(file)
--- a/
drivers/char/applicom.c
+++ b/
drivers/char/applicom.c
@@
-345,7
+345,6
@@
out:
free_irq(apbs[i].irq, &dummy);
iounmap(apbs[i].RamIO);
}
- pci_disable_device(dev);
return ret;
}