KVM: s390: Fixes for PFMF
authorThomas Huth <thuth@linux.vnet.ibm.com>
Mon, 9 Sep 2013 15:58:38 +0000 (17:58 +0200)
committerChristian Borntraeger <borntraeger@de.ibm.com>
Tue, 29 Apr 2014 13:01:53 +0000 (15:01 +0200)
Add a check for low-address protection to the PFMF handler and
convert real-addresses to absolute if necessary, as it is defined
in the Principles of Operations specification.

Signed-off-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
arch/s390/kvm/priv.c

index 27f9051a78f85700f19a0f07491cadd8c51d0c83..a47157bca8a6ddd53374c0df23b830239b02b211 100644 (file)
@@ -650,6 +650,11 @@ static int handle_pfmf(struct kvm_vcpu *vcpu)
                return kvm_s390_inject_program_int(vcpu, PGM_SPECIFICATION);
 
        start = vcpu->run->s.regs.gprs[reg2] & PAGE_MASK;
+       if (vcpu->run->s.regs.gprs[reg1] & PFMF_CF) {
+               if (kvm_s390_check_low_addr_protection(vcpu, start))
+                       return kvm_s390_inject_prog_irq(vcpu, &vcpu->arch.pgm);
+       }
+
        switch (vcpu->run->s.regs.gprs[reg1] & PFMF_FSC) {
        case 0x00000000:
                end = (start + (1UL << 12)) & ~((1UL << 12) - 1);
@@ -665,10 +670,15 @@ static int handle_pfmf(struct kvm_vcpu *vcpu)
                return kvm_s390_inject_program_int(vcpu, PGM_SPECIFICATION);
        }
        while (start < end) {
-               unsigned long useraddr;
-
-               useraddr = gmap_translate(start, vcpu->arch.gmap);
-               if (IS_ERR((void *)useraddr))
+               unsigned long useraddr, abs_addr;
+
+               /* Translate guest address to host address */
+               if ((vcpu->run->s.regs.gprs[reg1] & PFMF_FSC) == 0)
+                       abs_addr = kvm_s390_real_to_abs(vcpu, start);
+               else
+                       abs_addr = start;
+               useraddr = gfn_to_hva(vcpu->kvm, gpa_to_gfn(abs_addr));
+               if (kvm_is_error_hva(useraddr))
                        return kvm_s390_inject_program_int(vcpu, PGM_ADDRESSING);
 
                if (vcpu->run->s.regs.gprs[reg1] & PFMF_CF) {