cfg80211: add sanity check for retry limit in wext-compat
authorUjjal Roy <royujjal@gmail.com>
Thu, 9 Jan 2014 15:46:14 +0000 (21:16 +0530)
committerJohannes Berg <johannes.berg@intel.com>
Thu, 9 Jan 2014 16:05:28 +0000 (17:05 +0100)
Block setting the wrong values through iwconfig retry
command. Add sanity checking before sending the retry
limit to the driver.

Signed-off-by: Ujjal Roy <royujjal@gmail.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/wireless/wext-compat.c

index 051d961d4e289f56b1b9560ac5c41161f891fe95..5661a54ac7ee4ed1c1865d855e1b2681c67d07cc 100644 (file)
@@ -370,7 +370,7 @@ static int cfg80211_wext_siwretry(struct net_device *dev,
        u8 oshort = wdev->wiphy->retry_short;
        int err;
 
-       if (retry->disabled ||
+       if (retry->disabled || retry->value < 1 || retry->value > 255 ||
            (retry->flags & IW_RETRY_TYPE) != IW_RETRY_LIMIT)
                return -EINVAL;