fm10k: remove extraneous NULL check on l2_accel
authorJacob Keller <jacob.e.keller@intel.com>
Wed, 3 Jun 2015 23:31:04 +0000 (16:31 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 17 Jun 2015 21:20:56 +0000 (14:20 -0700)
l2_accel was checked for NULL at the top of fm10k_dfwd_del_station, and
we return if it is not defined. Due to this, we already know it can't be
null here so a separate check is meaningless. Discovered via cppcheck.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/fm10k/fm10k_netdev.c

index 4c6b5111156622dafae42a9040b92e766da9a39a..99228bf46c1202170ef8eb934624e15d99a257d9 100644 (file)
@@ -1333,8 +1333,7 @@ static void fm10k_dfwd_del_station(struct net_device *dev, void *priv)
        dglort.rss_l = fls(interface->ring_feature[RING_F_RSS].mask);
        dglort.pc_l = fls(interface->ring_feature[RING_F_QOS].mask);
        dglort.glort = interface->glort;
-       if (l2_accel)
-               dglort.shared_l = fls(l2_accel->size);
+       dglort.shared_l = fls(l2_accel->size);
        hw->mac.ops.configure_dglort_map(hw, &dglort);
 
        /* If table is empty remove it */