video: pxa168fb: remove a redundant pxa168fb_check_var call
authoraxel lin <axel.lin@gmail.com>
Fri, 21 Jan 2011 11:18:06 +0000 (11:18 +0000)
committerPaul Mundt <lethal@linux-sh.org>
Tue, 25 Jan 2011 06:09:19 +0000 (15:09 +0900)
Current implementation calls pxa168fb_check_var twice in pxa168fb_probe.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
drivers/video/pxa168fb.c

index cea6403ae71c16ffbcded14282db1552244f8833..35f61dd0cb3a43f5a9e3f70ac0dc5a07136a91b1 100644 (file)
@@ -701,16 +701,12 @@ static int __devinit pxa168fb_probe(struct platform_device *pdev)
         */
        pxa168fb_init_mode(info, mi);
 
-       ret = pxa168fb_check_var(&info->var, info);
-       if (ret)
-               goto failed_free_fbmem;
-
        /*
         * Fill in sane defaults.
         */
        ret = pxa168fb_check_var(&info->var, info);
        if (ret)
-               goto failed;
+               goto failed_free_fbmem;
 
        /*
         * enable controller clock