Avoid creating a SlotIndex from the end() iterator.
authorJakob Stoklund Olesen <stoklund@2pi.dk>
Fri, 8 Mar 2013 18:08:54 +0000 (18:08 +0000)
committerJakob Stoklund Olesen <stoklund@2pi.dk>
Fri, 8 Mar 2013 18:08:54 +0000 (18:08 +0000)
No test case, spotted by inspection.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@176705 91177308-0d34-0410-b5e6-96231b3b80d8

include/llvm/CodeGen/SlotIndexes.h

index 78fb233e5ffaa3c29d9d2faaddb6869f37048a50..0f85c994a22eb30fef387cf8eb575bec876b8d0d 100644 (file)
@@ -396,12 +396,16 @@ namespace llvm {
       return index.isValid() ? index.listEntry()->getInstr() : 0;
     }
 
-    /// Returns the next non-null index.
-    SlotIndex getNextNonNullIndex(SlotIndex index) {
-      IndexList::iterator itr(index.listEntry());
-      ++itr;
-      while (itr != indexList.end() && itr->getInstr() == 0) { ++itr; }
-      return SlotIndex(itr, index.getSlot());
+    /// Returns the next non-null index, if one exists.
+    /// Otherwise returns getLastIndex().
+    SlotIndex getNextNonNullIndex(SlotIndex Index) {
+      IndexList::iterator I = Index.listEntry();
+      IndexList::iterator E = indexList.end();
+      while (I != E)
+        if ((++I)->getInstr())
+          return SlotIndex(I, Index.getSlot());
+      // We reached the end of the function.
+      return getLastIndex();
     }
 
     /// getIndexBefore - Returns the index of the last indexed instruction