Properly handle linking of strong alias with weak function, this fixes PR2883
authorAnton Korobeynikov <asl@math.spbu.ru>
Wed, 15 Oct 2008 20:10:08 +0000 (20:10 +0000)
committerAnton Korobeynikov <asl@math.spbu.ru>
Wed, 15 Oct 2008 20:10:08 +0000 (20:10 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@57594 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Linker/LinkModules.cpp

index cee3b23e2a4ef4903fec4da66305d8c1478ce461..b958e34fc78b6304c9e2f24ea37ce59109882f0a 100644 (file)
@@ -984,7 +984,7 @@ static bool LinkFunctionProtos(Module *Dest, const Module *Src,
       // The only valid mappings are:
       // - SF is external declaration, which is effectively a no-op.
       // - SF is weak, when we just need to throw SF out.
-      if (!SF->isDeclaration())
+      if (!SF->isDeclaration() && !SF->mayBeOverridden())
         return Error(Err, "Function-Alias Collision on '" + SF->getName() +
                      "': symbol multiple defined");
     }