ARM: 7308/1: vfp: flush thread hwstate before copying ptrace registers
authorWill Deacon <will.deacon@arm.com>
Mon, 30 Jan 2012 19:23:29 +0000 (20:23 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Feb 2012 19:06:05 +0000 (11:06 -0800)
commit 8130b9d7b9d858aa04ce67805e8951e3cb6e9b2f upstream.

If we are context switched whilst copying into a thread's
vfp_hard_struct then the partial copy may be corrupted by the VFP
context switching code (see "ARM: vfp: flush thread hwstate before
restoring context from sigframe").

This patch updates the ptrace VFP set code so that the thread state is
flushed before the copy, therefore disabling VFP and preventing
corruption from occurring.

Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm/kernel/ptrace.c

index 7f1e1338e4ddd9e68693a830f95cd087d992b945..172ae01c26e09060cdc517c12f6f16147f43d865 100644 (file)
@@ -746,8 +746,8 @@ static int vfp_set(struct task_struct *target,
        if (ret)
                return ret;
 
-       thread->vfpstate.hard = new_vfp;
        vfp_flush_hwstate(thread);
+       thread->vfpstate.hard = new_vfp;
 
        return 0;
 }