Fix a silly error I introduce in r131951.
authorRafael Espindola <rafael.espindola@gmail.com>
Tue, 7 Jun 2011 23:26:45 +0000 (23:26 +0000)
committerRafael Espindola <rafael.espindola@gmail.com>
Tue, 7 Jun 2011 23:26:45 +0000 (23:26 +0000)
Fixes PR10095.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@132735 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/TargetLoweringObjectFileImpl.cpp
test/CodeGen/X86/eh_frame.ll

index 4e2888ddfc452c6f5c55fea6942e2fe25409b069..cdac42d1bf17531405ac4af6fa34477ffaba817d 100644 (file)
@@ -255,9 +255,6 @@ getELFKindForNamedSection(StringRef Name, SectionKind K) {
       Name.startswith(".llvm.linkonce.tb."))
     return SectionKind::getThreadBSS();
 
-  if (Name == ".eh_frame")
-    return SectionKind::getReadOnlyWithRel();
-
   return K;
 }
 
@@ -290,7 +287,7 @@ getELFSectionFlags(SectionKind K) {
   if (K.isText())
     Flags |= ELF::SHF_EXECINSTR;
 
-  if (K.isWriteable() && !K.isReadOnlyWithRel())
+  if (K.isWriteable())
     Flags |= ELF::SHF_WRITE;
 
   if (K.isThreadLocal())
index e8d3c87d41b6654b553bde45bd06703f85b6d947..3b792b235cb5e15e6c62c4d7a3bfa8430c9d9f45 100644 (file)
@@ -1,5 +1,14 @@
-; RUN: llc < %s -mtriple x86_64-unknown-linux-gnu | FileCheck %s
+; RUN: llc < %s -mtriple x86_64-unknown-linux-gnu | FileCheck -check-prefix=STATIC %s
+; RUN: llc < %s -mtriple x86_64-unknown-linux-gnu -relocation-model=pic | FileCheck -check-prefix=PIC %s
 
 @__FRAME_END__ = constant [1 x i32] zeroinitializer, section ".eh_frame"
 
-; CHECK: .section      .eh_frame,"a",@progbits
+@foo = external global i32
+@bar1 = constant i8* bitcast (i32* @foo to i8*), section "my_bar1", align 8
+
+
+; STATIC: .section     .eh_frame,"a",@progbits
+; STATIC: .section     my_bar1,"a",@progbits
+
+; PIC: .section        .eh_frame,"a",@progbits
+; PIC: .section        my_bar1,"aw",@progbits