libertas: add comment re: v10 firmware key handling
authorJohn W. Linville <linville@tuxdriver.com>
Wed, 27 Jan 2010 19:23:17 +0000 (14:23 -0500)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 27 Jan 2010 20:02:03 +0000 (15:02 -0500)
Comment text suggested by Dan Williams <dcbw@redhat.com> in
<1263952092.4481.2.camel@localhost.localdomain>.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/libertas/assoc.c

index 0979b07799a070fa037a77139d8642cbb3237ae2..f03d5e4e59c31c1da78c271d4665f158825c712f 100644 (file)
@@ -2062,6 +2062,11 @@ void lbs_association_worker(struct work_struct *work)
                        goto out;
        }
 
+       /*
+        * v10 FW wants WPA keys to be set/cleared before WEP key operations,
+        * otherwise it will fail to correctly associate to WEP networks.
+        * Other firmware versions don't appear to care.
+        */
        if (test_bit(ASSOC_FLAG_WPA_MCAST_KEY, &assoc_req->flags) ||
            test_bit(ASSOC_FLAG_WPA_UCAST_KEY, &assoc_req->flags)) {
                ret = assoc_helper_wpa_keys(priv, assoc_req);