Fix <rdar://problem/8282498> even if it doesn't reproduce on trunk.
authorJakob Stoklund Olesen <stoklund@2pi.dk>
Wed, 11 Aug 2010 23:08:22 +0000 (23:08 +0000)
committerJakob Stoklund Olesen <stoklund@2pi.dk>
Wed, 11 Aug 2010 23:08:22 +0000 (23:08 +0000)
When a register is defined by a partial load:

  %reg1234:sub_32 = MOV32mr <fi#-1>; GR64:%reg1234

That load cannot be folded into an instruction using the full 64-bit register.
It would become a 64-bit load.

This is related to the recent change to have isLoadFromStackSlot return false on
a sub-register load.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@110874 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Target/X86/X86InstrInfo.cpp

index 4ee0c0af835381fd942c9d822956cae53a313626..7d973ea89d313ee48c2896de54f1976d3fbe8bea 100644 (file)
@@ -2410,6 +2410,11 @@ MachineInstr* X86InstrInfo::foldMemoryOperandImpl(MachineFunction &MF,
   } else if (Ops.size() != 1)
     return NULL;
 
+  // Make sure the subregisters match.
+  // Otherwise we risk changing the size of the load.
+  if (LoadMI->getOperand(0).getSubReg() != MI->getOperand(Ops[0]).getSubReg())
+    return NULL;
+
   SmallVector<MachineOperand,X86::AddrNumOperands> MOs;
   switch (LoadMI->getOpcode()) {
   case X86::V_SET0PS: