x86/mce: Avoid showing repetitive message from intel_init_thermal()
authorRakib Mullick <rakib.mullick@gmail.com>
Thu, 18 Sep 2014 19:22:15 +0000 (01:22 +0600)
committerIngo Molnar <mingo@kernel.org>
Fri, 19 Sep 2014 10:56:05 +0000 (12:56 +0200)
intel_init_thermal() is called from a) at the time of system initializing
and b) at the time of system resume to initialize thermal
monitoring.

In case when thermal monitoring is handled by SMI, we get to know it via
printk(). Currently it gives the message at both cases, but its okay if
we get it only once and no need to get the same message at every time
system resumes.

So, limit showing this message only at system boot time by avoid showing
at system resume and reduce abusing kernel log buffer.

Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Tony Luck <tony.luck@intel.com>
Link: http://lkml.kernel.org/r/1411068135.5121.10.camel@localhost.localdomain
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/cpu/mcheck/therm_throt.c

index 36a1bb6d1ee0d431752a170714aa6a43576ffada..1af51b1586d7f7ae0bfa65ec377634b2d8fa39c2 100644 (file)
@@ -498,8 +498,8 @@ void intel_init_thermal(struct cpuinfo_x86 *c)
 
 
        if ((l & MSR_IA32_MISC_ENABLE_TM1) && (h & APIC_DM_SMI)) {
-               printk(KERN_DEBUG
-                      "CPU%d: Thermal monitoring handled by SMI\n", cpu);
+               if (system_state == SYSTEM_BOOTING)
+                       printk(KERN_DEBUG "CPU%d: Thermal monitoring handled by SMI\n", cpu);
                return;
        }