Remove Value::setName(const char*).

 - Split into a separate patch because there is a slight functionality change,
   it is no longer valid to call setName(0), which was equivalent to
   setName(""). I'm hoping no one depends on this...

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@77099 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm/Value.h b/include/llvm/Value.h
index 584b80e3e46dd4da4d8d1e4d99da4933ce6074e7..0ff0f7ebc96f0aafd7d47a58b811622bedca2cf8 100644 (file)
--- a/include/llvm/Value.h
+++ b/include/llvm/Value.h
@@ -130,7 +130,6 @@ public:
 
   void setName(const Twine &Name);
   void setName(const char *Name, unsigned NameLen);
-  void setName(const char *Name);  // Takes a null-terminated string.
 
   
   /// takeName - transfer the name from V to this value, setting V's name to

diff --git a/lib/VMCore/Value.cpp b/lib/VMCore/Value.cpp
index 9d6af5a334eebaabaa350b5a45793427e5dc1694..1b9fe51332f49fc142cb5562e7b0022a01eb2e80 100644 (file)
--- a/lib/VMCore/Value.cpp
+++ b/lib/VMCore/Value.cpp
@@ -167,9 +167,7 @@ unsigned Value::getNameLen() const {
 
 
 std::string Value::getNameStr() const {
-  if (Name == 0) return "";
-  return std::string(Name->getKeyData(),
-                     Name->getKeyData()+Name->getKeyLength());
+  return getName().str();
 }
 
 void Value::setName(const Twine &Name) {
@@ -178,10 +176,6 @@ void Value::setName(const Twine &Name) {
   setName(NameData.begin(), NameData.size());
 }
 
-void Value::setName(const char *Name) {
-  setName(Name, Name ? strlen(Name) : 0);
-}
-
 void Value::setName(const char *NameStr, unsigned NameLen) {
   if (NameLen == 0 && !hasName()) return;
   assert(getType() != Type::VoidTy && "Cannot assign a name to void values!");