firmware: Sigma: Skip header during CRC generation
authorLars-Peter Clausen <lars@metafoo.de>
Mon, 28 Nov 2011 08:44:15 +0000 (09:44 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 9 Dec 2011 16:52:39 +0000 (08:52 -0800)
commit c56935bdc0a8edf50237d3b0205133a5b0adc604 upstream.

The firmware header is not part of the CRC, so skip it. Otherwise the firmware
will be rejected due to non-matching CRCs.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/firmware/sigma.c

index c780baa59ed965759a322db926f1e4fc56bcf991..36265de0a9e8acad8ac9e45c5e49ed8c00dd98e9 100644 (file)
@@ -130,7 +130,8 @@ int process_sigma_firmware(struct i2c_client *client, const char *name)
        if (memcmp(ssfw_head->magic, SIGMA_MAGIC, ARRAY_SIZE(ssfw_head->magic)))
                goto done;
 
-       crc = crc32(0, fw->data, fw->size);
+       crc = crc32(0, fw->data + sizeof(*ssfw_head),
+                       fw->size - sizeof(*ssfw_head));
        pr_debug("%s: crc=%x\n", __func__, crc);
        if (crc != ssfw_head->crc)
                goto done;