regmap: irq: Factor register read out of the IRQ parsing loop
authorMark Brown <broonie@opensource.wolfsonmicro.com>
Thu, 3 Jan 2013 13:58:33 +0000 (13:58 +0000)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Thu, 3 Jan 2013 14:30:33 +0000 (14:30 +0000)
In preparation for adding back support for block reads.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
drivers/base/regmap/regmap-irq.c

index 91294935130e692b08b3d2916f3fc4fd13fb6a8c..329be98367160dc786b278ccc346d5a9263b112d 100644 (file)
@@ -170,13 +170,6 @@ static irqreturn_t regmap_irq_thread(int irq, void *d)
                }
        }
 
-       /*
-        * Ignore masked IRQs and ack if we need to; we ack early so
-        * there is no race between handling and acknowleding the
-        * interrupt.  We assume that typically few of the interrupts
-        * will fire simultaneously so don't worry about overhead from
-        * doing a write per register.
-        */
        for (i = 0; i < data->chip->num_regs; i++) {
                ret = regmap_read(map, chip->status_base + (i * map->reg_stride
                                   * data->irq_reg_stride),
@@ -189,7 +182,16 @@ static irqreturn_t regmap_irq_thread(int irq, void *d)
                                pm_runtime_put(map->dev);
                        return IRQ_NONE;
                }
+       }
 
+       /*
+        * Ignore masked IRQs and ack if we need to; we ack early so
+        * there is no race between handling and acknowleding the
+        * interrupt.  We assume that typically few of the interrupts
+        * will fire simultaneously so don't worry about overhead from
+        * doing a write per register.
+        */
+       for (i = 0; i < data->chip->num_regs; i++) {
                data->status_buf[i] &= ~data->mask_buf[i];
 
                if (data->status_buf[i] && chip->ack_base) {