mtd: fsl_ifc_nand: remove incorrect kfree()
authorBrian Norris <computersforpeace@gmail.com>
Fri, 29 Mar 2013 04:28:56 +0000 (21:28 -0700)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Mon, 5 Aug 2013 17:58:08 +0000 (18:58 +0100)
The struct fsl_ifc_mtd is allocated with devm_kzalloc, so its memory
is "managed" automatically by the kernel. That is, we do not need to
free it explicitly; it will be freed when the device is removed. And we
*certainly* shouldn't free it with a regular kfree().

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
drivers/mtd/nand/fsl_ifc_nand.c

index f1f7f12ab50184b3bc233e360a899b998ea8c724..180bfa798e1325efec660367a76b26773320b4df 100644 (file)
@@ -908,7 +908,6 @@ static int fsl_ifc_chip_remove(struct fsl_ifc_mtd *priv)
 
        ifc_nand_ctrl->chips[priv->bank] = NULL;
        dev_set_drvdata(priv->dev, NULL);
-       kfree(priv);
 
        return 0;
 }