ARM: OMAP: musb: Remove a redundant omap4430_phy_init call in usb_musb_init
authorAxel Lin <axel.lin@gmail.com>
Fri, 30 Sep 2011 18:05:55 +0000 (11:05 -0700)
committerTony Lindgren <tony@atomide.com>
Fri, 30 Sep 2011 18:05:55 +0000 (11:05 -0700)
Current code calls omap4430_phy_init() twice in usb_musb_init().
Calling omap4430_phy_init() once is enough.
This patch removes the first omap4430_phy_init() call, which using an
uninitialized pointer as parameter.

This patch elimates below build warning:
arch/arm/mach-omap2/usb-musb.c: In function 'usb_musb_init':
arch/arm/mach-omap2/usb-musb.c:141: warning: 'dev' may be used uninitialized in this function

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Bjarne Steinsbo <bsteinsbo@gmail.com>
Acked-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/mach-omap2/usb-musb.c

index a65145b02a5583cc7b3564727034e4c7c9fb2809..19e4dac62a8c1c051ff842144cfbcd3ac1dcaebc 100644 (file)
@@ -137,9 +137,6 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data)
        musb_plat.mode = board_data->mode;
        musb_plat.extvbus = board_data->extvbus;
 
-       if (cpu_is_omap44xx())
-               omap4430_phy_init(dev);
-
        if (cpu_is_omap3517() || cpu_is_omap3505()) {
                oh_name = "am35x_otg_hs";
                name = "musb-am35x";