Bnx2x: remove redundant D0 power state set
authorYijing Wang <wangyijing@huawei.com>
Tue, 18 Jun 2013 08:05:39 +0000 (16:05 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 20 Jun 2013 05:22:56 +0000 (22:22 -0700)
Pci_enable_device() will set device power state to D0,
so it's no need to do it again in bnx2x_init_dev().
Also remove redundant PM Cap find code, because pci core
has been saved the pci device pm cap value.

Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Cc: Eilon Greenstein <eilong@broadcom.com>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Acked-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c

index f0d21faf71ece2ec9bcf9f7b7d98890f344fac05..c962d66a1a79874ecef705d7961485722d419725 100644 (file)
@@ -12091,7 +12091,7 @@ static int bnx2x_init_dev(struct bnx2x *bp, struct pci_dev *pdev,
        }
 
        if (IS_PF(bp)) {
-               bp->pm_cap = pci_find_capability(pdev, PCI_CAP_ID_PM);
+               bp->pm_cap = pdev->pm_cap;
                if (bp->pm_cap == 0) {
                        dev_err(&bp->pdev->dev,
                                "Cannot find power management capability, aborting\n");
@@ -12140,8 +12140,6 @@ static int bnx2x_init_dev(struct bnx2x *bp, struct pci_dev *pdev,
        }
        BNX2X_DEV_INFO("me reg PF num: %d\n", bp->pf_num);
 
-       bnx2x_set_power_state(bp, PCI_D0);
-
        /* clean indirect addresses */
        pci_write_config_dword(bp->pdev, PCICFG_GRC_ADDRESS,
                               PCICFG_VENDOR_ID_OFFSET);