Thermal/int340x: avoid unnecessary pointer casting
authorJacob Pan <jacob.jun.pan@linux.intel.com>
Tue, 4 Nov 2014 23:53:34 +0000 (15:53 -0800)
committerZhang Rui <rui.zhang@intel.com>
Tue, 9 Dec 2014 03:31:19 +0000 (11:31 +0800)
Avoid pointer casting which may also lead to problems on big endian
64 bit systems.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
drivers/thermal/int340x_thermal/acpi_thermal_rel.c

index 0d8db808f0ae0fb983e207f787f4374eb37c7227..ac5c40558b844c4acfdc0d5c7f9acb8705f68283 100644 (file)
@@ -317,21 +317,21 @@ static long acpi_thermal_rel_ioctl(struct file *f, unsigned int cmd,
 {
        int ret = 0;
        unsigned long length = 0;
-       unsigned long count = 0;
+       int count = 0;
        char __user *arg = (void __user *)__arg;
        struct trt *trts;
        struct art *arts;
 
        switch (cmd) {
        case ACPI_THERMAL_GET_TRT_COUNT:
-               ret = acpi_parse_trt(acpi_thermal_rel_handle, (int *)&count,
+               ret = acpi_parse_trt(acpi_thermal_rel_handle, &count,
                                &trts, false);
                kfree(trts);
                if (!ret)
                        return put_user(count, (unsigned long __user *)__arg);
                return ret;
        case ACPI_THERMAL_GET_TRT_LEN:
-               ret = acpi_parse_trt(acpi_thermal_rel_handle, (int *)&count,
+               ret = acpi_parse_trt(acpi_thermal_rel_handle, &count,
                                &trts, false);
                kfree(trts);
                length = count * sizeof(union trt_object);
@@ -341,14 +341,14 @@ static long acpi_thermal_rel_ioctl(struct file *f, unsigned int cmd,
        case ACPI_THERMAL_GET_TRT:
                return fill_trt(arg);
        case ACPI_THERMAL_GET_ART_COUNT:
-               ret = acpi_parse_art(acpi_thermal_rel_handle, (int *)&count,
+               ret = acpi_parse_art(acpi_thermal_rel_handle, &count,
                                &arts, false);
                kfree(arts);
                if (!ret)
                        return put_user(count, (unsigned long __user *)__arg);
                return ret;
        case ACPI_THERMAL_GET_ART_LEN:
-               ret = acpi_parse_art(acpi_thermal_rel_handle, (int *)&count,
+               ret = acpi_parse_art(acpi_thermal_rel_handle, &count,
                                &arts, false);
                kfree(arts);
                length = count * sizeof(union art_object);