static constexpr in enclosing class + lambdas make compilers unhappy?
authorTudor Bosman <tudorb@fb.com>
Wed, 14 Nov 2012 02:09:24 +0000 (18:09 -0800)
committerJordan DeLong <jdelong@fb.com>
Sun, 16 Dec 2012 22:45:17 +0000 (14:45 -0800)
Test Plan: build

Reviewed By: dneiter@fb.com

FB internal diff: D630324

folly/experimental/StringGen-inl.h

index 84c42492000655ddeeffef50b78f8cb82de2f1af..e3ad981b58a6cf12cc3d3f3d8bf60bc1e7aebf9b 100644 (file)
@@ -48,7 +48,6 @@ class StringResplitter : public Operator<StringResplitter> {
   class Generator : public GenImpl<StringPiece, Generator<Source>> {
     Source source_;
     char delimiter_;
-    static constexpr size_t kDefaultLineSize = 256;
    public:
     Generator(Source source, char delimiter)
       : source_(std::move(source)), delimiter_(delimiter) { }
@@ -85,6 +84,7 @@ class StringResplitter : public Operator<StringResplitter> {
           if (!buffer) {
             // Arbitrarily assume that we have half a line and get enough
             // room for twice that.
+            constexpr size_t kDefaultLineSize = 256;
             buffer = IOBuf::create(std::max(kDefaultLineSize, 2 * in.size()));
           }
           buffer->reserve(0, in.size());