[media] mb86a20s: Fix estimate_rate setting
authorMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 8 Apr 2013 00:06:12 +0000 (21:06 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 8 Apr 2013 10:11:06 +0000 (07:11 -0300)
As reported by Dan Carpenter <dan.carpenter@oracle.com>:
        Smatch warnings:
        drivers/media/dvb-frontends/mb86a20s.c:644 mb86a20s_layer_bitrate() error: buffer overflow 'state->estimated_rate' 3 <= 3
What happens there is that estimate_rate index should be the layer
number, and not the guard interval.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb-frontends/mb86a20s.c

index f2565896ce425dda60c82a9d50dc8fcba7e00493..d25df75ed404b28100fe22a1e34728e60d4f9f18 100644 (file)
@@ -642,7 +642,7 @@ static void mb86a20s_layer_bitrate(struct dvb_frontend *fe, u32 layer,
               __func__, 'A' + layer, segment * isdbt_rate[m][f][i]/1000,
                rate, rate);
 
-       state->estimated_rate[i] = rate;
+       state->estimated_rate[layer] = rate;
 }