ksz884x: remove unnecessary setting of skb->dev
authorJon Mason <jdmason@kudzu.us>
Mon, 9 Jul 2012 14:09:29 +0000 (14:09 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 11 Jul 2012 06:24:57 +0000 (23:24 -0700)
skb->dev is being unnecessarily set during ring init.  It is already being set
to the proper value when eth_type_trans is called on packet receive, and the
skb->dev is not referenced anywhere else in the code.

Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/micrel/ksz884x.c

index 24a4c5716cf52c26a1f2cdc75dea6082a52462b3..37b44b91950b77071041cf405ab6d3b2822c274b 100644 (file)
@@ -4480,14 +4480,12 @@ static void ksz_init_rx_buffers(struct dev_info *adapter)
                dma_buf->len = adapter->mtu;
                if (!dma_buf->skb)
                        dma_buf->skb = alloc_skb(dma_buf->len, GFP_ATOMIC);
-               if (dma_buf->skb && !dma_buf->dma) {
-                       dma_buf->skb->dev = adapter->dev;
+               if (dma_buf->skb && !dma_buf->dma)
                        dma_buf->dma = pci_map_single(
                                adapter->pdev,
                                skb_tail_pointer(dma_buf->skb),
                                dma_buf->len,
                                PCI_DMA_FROMDEVICE);
-               }
 
                /* Set descriptor. */
                set_rx_buf(desc, dma_buf->dma);