staging: vt6656: [BUG] out of bound array reference in RFbSetPower.
authorMalcolm Priestley <tvboxspy@gmail.com>
Sun, 7 Oct 2012 07:27:00 +0000 (08:27 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 22 Oct 2012 20:26:40 +0000 (13:26 -0700)
Calling RFbSetPower with uCH zero value will cause out of bound array reference.

This causes 64 bit kernels to oops on boot.

Note: Driver does not function on 64 bit kernels and should be
blacklisted on them.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6656/rf.c

index 593cdc713b0e21413e6044f1fd70a2801c099ada..74c0598e37b7c4b03742b06375a56adc10f34994 100644 (file)
@@ -769,6 +769,9 @@ BYTE    byPwr = pDevice->byCCKPwr;
         return TRUE;
     }
 
+       if (uCH == 0)
+               return -EINVAL;
+
     switch (uRATE) {
     case RATE_1M:
     case RATE_2M: