Whitelist files and block devices instead of blacklisting fifos and
authorDan Gohman <dan433584@gmail.com>
Tue, 19 Feb 2013 19:36:55 +0000 (19:36 +0000)
committerDan Gohman <dan433584@gmail.com>
Tue, 19 Feb 2013 19:36:55 +0000 (19:36 +0000)
character devices.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@175549 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Support/MemoryBuffer.cpp

index b0a20853b5c19d56fbadbb112d481ecc90cbc40f..0d5d4d7954f0d99bb915fcdfe8d0ed85c43769e5 100644 (file)
@@ -322,9 +322,10 @@ error_code MemoryBuffer::getOpenFile(int FD, const char *Filename,
         return error_code(errno, posix_category());
       }
 
-      // If this is a named pipe or character device, we can't trust the size.
-      // Create the memory buffer by copying off the stream.
-      if (S_ISFIFO(FileInfo.st_mode) || S_ISCHR(FileInfo.st_mode)) {
+      // If this not a file or a block device (e.g. it's a named pipe
+      // or character device), we can't trust the size. Create the memory
+      // buffer by copying off the stream.
+      if (!S_ISREG(FileInfo.st_mode) && !S_ISBLK(FileInfo.st_mode)) {
         return getMemoryBufferForStream(FD, Filename, result);
       }