uwb: Use kcalloc instead of kzalloc to allocate array
authorThomas Meyer <thomas@m3y3r.de>
Tue, 29 Nov 2011 21:08:00 +0000 (22:08 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sat, 10 Dec 2011 00:18:20 +0000 (16:18 -0800)
The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/uwb/est.c

index de81ebf51784d086085e12f869dac022946caf0f..86ed7e61e597404e11b6cbc084e63e2ae48b93d7 100644 (file)
@@ -184,7 +184,7 @@ int uwb_est_create(void)
 
        uwb_est_size = 2;
        uwb_est_used = 0;
-       uwb_est = kzalloc(uwb_est_size * sizeof(uwb_est[0]), GFP_KERNEL);
+       uwb_est = kcalloc(uwb_est_size, sizeof(uwb_est[0]), GFP_KERNEL);
        if (uwb_est == NULL)
                return -ENOMEM;