Btrfs: NUL-terminate path buffer in DEV_INFO ioctl result
authorJim Meyering <jim@meyering.net>
Thu, 26 Apr 2012 16:36:56 +0000 (18:36 +0200)
committerJosef Bacik <josef@redhat.com>
Wed, 30 May 2012 14:23:31 +0000 (10:23 -0400)
A device with name of length BTRFS_DEVICE_PATH_NAME_MAX or longer
would not be NUL-terminated in the DEV_INFO ioctl result buffer.

Signed-off-by: Jim Meyering <meyering@redhat.com>
fs/btrfs/ioctl.c

index 9ebb2c7145ad2f758ca990d2285b790f742f0319..3d8ab27622cd7fd3463409c1c5b3cb2e8f7ca020 100644 (file)
@@ -2263,10 +2263,12 @@ static long btrfs_ioctl_dev_info(struct btrfs_root *root, void __user *arg)
        di_args->bytes_used = dev->bytes_used;
        di_args->total_bytes = dev->total_bytes;
        memcpy(di_args->uuid, dev->uuid, sizeof(di_args->uuid));
-       if (dev->name)
+       if (dev->name) {
                strncpy(di_args->path, dev->name, sizeof(di_args->path));
-       else
+               di_args->path[sizeof(di_args->path) - 1] = 0;
+       } else {
                di_args->path[0] = '\0';
+       }
 
 out:
        if (ret == 0 && copy_to_user(arg, di_args, sizeof(*di_args)))