[media] staging: bcm2048: Delete an unnecessary check before the function call "video...
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 2 Feb 2015 12:20:23 +0000 (09:20 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Mon, 2 Feb 2015 15:34:46 +0000 (13:34 -0200)
The video_unregister_device() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/staging/media/bcm2048/radio-bcm2048.c

index 4d5e2f400ff607a8bfbdd9ae33a2fb86a4444aa8..53825066791875d20f7b289cfaa56e1b79ba189d 100644 (file)
@@ -2684,9 +2684,7 @@ static int __exit bcm2048_i2c_driver_remove(struct i2c_client *client)
                vd = bdev->videodev;
 
                bcm2048_sysfs_unregister_properties(bdev, ARRAY_SIZE(attrs));
-
-               if (vd)
-                       video_unregister_device(vd);
+               video_unregister_device(vd);
 
                if (bdev->power_state)
                        bcm2048_set_power_state(bdev, BCM2048_POWER_OFF);