sky2: fix hard hang with netconsoling and iface going up
authorAlexey Dobriyan <adobriyan@gmail.com>
Fri, 30 Jan 2009 21:45:31 +0000 (13:45 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 Jan 2009 22:06:26 +0000 (14:06 -0800)
Printing anything over netconsole before hw is up and running is,
of course, not going to work.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/sky2.c

index 3668e81e474ddbe3f83438378527e5af12cdb2d5..994703cc0db32c87229f7754f1a246c1cc44d9ea 100644 (file)
@@ -1403,9 +1403,6 @@ static int sky2_up(struct net_device *dev)
 
        }
 
-       if (netif_msg_ifup(sky2))
-               printk(KERN_INFO PFX "%s: enabling interface\n", dev->name);
-
        netif_carrier_off(dev);
 
        /* must be power of 2 */
@@ -1484,6 +1481,9 @@ static int sky2_up(struct net_device *dev)
        sky2_write32(hw, B0_IMSK, imask);
 
        sky2_set_multicast(dev);
+
+       if (netif_msg_ifup(sky2))
+               printk(KERN_INFO PFX "%s: enabling interface\n", dev->name);
        return 0;
 
 err_out: